Dokuwiki Blockquote Plugin

Tasklist

FS#25 - Action-component for toolbarbutton seems broken.

Attached to Project: Dokuwiki Blockquote Plugin
Opened by Anonymous Submitter - Sunday, 04 May 2008, 00:30 GMT+2
Last edited by Gina Häußge (foosel) - Sunday, 04 May 2008, 11:56 GMT+2
Task Type Bug Report
Category Backend / Core
Status Closed
Assigned To Gina Häußge (foosel)
Operating System All
Severity Low
Priority Normal
Reported Version 2007/10/27
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The action-component in v.20080406 (running on DW RC2-20080411) seems broken. The button isn't displayed due to a Javascript error which isn't very descriptive:

Error: text has no properties
Sourcefile: http://xxx.xxx.xxx/lib/exe/js.php?edit=1&write=1
Line: 1

After some investigation (the error pointed me to a empty argument) I tried to replace the following line in action.php
'title' => $lang['qb_blockquote'],
with:
'title' => 'Mark text as blockquote',
(so actually reverting the i18n) and now the Javascript-error has disappeared.

So it looks there's something wrong with the code for the i18n. I took a quick look but haven't found the (correct) solution.

BTW: This seems also happening with the Keyboard-plugin, though I guess the code it uses is also outdated ($contr instead of $controller).
This task depends upon

Closed by  Gina Häußge (foosel)
Sunday, 04 May 2008, 11:56 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed for both blockquote and keyboard plugin, new releases are out.

Loading...